Add Siri support to start and stop the VPN. #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
changed the base branch from
main
to
diego/vpn-control-widget
diegoreymendez
merged commit b05a83c
into
diego/vpn-control-widget
12 of 15 checks passed
|
Merging this to the parent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1208485618883329/f
Description
Adds Siri support to start and stop the VPN.
Testing:
IMPORTANT: clean your build before running this as shortcuts seem to be flakey at first.
Definition of Done (Internal Only):
Copy Testing:
’rather than'Internal references:
Software Engineering Expectations
Technical Design Template